search

Netflix / falcor-express

Express Middleware for Hosting Falcor Data Sources.
Apache License 2.0
62 stars 25 forks source link

Return 400 if invalid query string args #16

Open jhusain opened 9 years ago

jhusain commented 9 years ago

If any query string args are invalid, for example invalid JSON in path, we need to catch these errors and send back HTTP 400.

ThePrimeagen commented 9 years ago

You must mean 500 correct?

Doh! of course, 400.

mac-a1 commented 9 years ago

400 Bad Request seems appropriate for an invalid JSON path.

On Jun 15, 2015, at 3:11 PM, Michael Paulson notifications@github.com wrote:

You must mean 500 correct?

— Reply to this email directly or view it on GitHub https://github.com/Netflix/falcor-express/issues/16#issuecomment-112224461.

jhusain commented 9 years ago

Yeah it was intentional.

JH

On Jun 15, 2015, at 3:19 PM, mac-a1 notifications@github.com wrote:

400 Bad Request seems appropriate for an invalid JSON path.

On Jun 15, 2015, at 3:11 PM, Michael Paulson notifications@github.com wrote:

You must mean 500 correct?

— Reply to this email directly or view it on GitHub https://github.com/Netflix/falcor-express/issues/16#issuecomment-112224461.

— Reply to this email directly or view it on GitHub.