search

Netflix / falcor-router

A Falcor JavaScript DataSource which creates a Virtual JSON Graph document on your app server.
http://netflix.github.io/falcor
Apache License 2.0
104 stars 46 forks source link

fix(Rx): make sure all necessary operators are added for router inter… #199

Closed benlesh closed 7 years ago

benlesh commented 7 years ago

…nal use

There was an issue where all unit tests would pass even though all of the appropriate operators for Rx usage inside of the router were not added. This is because importing all of Rx (as the tests had done) adds all operators by default.

This change forces the tests to require the same observable that the router is using, and for any additional operators or functionality, the tests are pulling in those bits from RxJS directly without mutating the prototype.

We should be more careful from now on to make sure no tests bring in all of Rx.

benlesh commented 7 years ago

related to https://github.com/Netflix/falcor-restify/issues/5

cc @sdesai @jhusain

benlesh commented 7 years ago

FYI: after this change, we'll want to do a patch release.