search

Netflix / falcor-router

A Falcor JavaScript DataSource which creates a Virtual JSON Graph document on your app server.
http://netflix.github.io/falcor
Apache License 2.0
104 stars 46 forks source link

Handle Falcor style observables from unhandled path datasource. #212

Closed lrowe closed 7 years ago

sdesai commented 7 years ago

This seems fine to me (it's what we were patching locally in the some of the middleware we've been using). Feel free to merge. Bumping up the travis yml to go with Node 4, 6 should fix the build issue.

lrowe commented 7 years ago

I think the local patching (using Rx4) was to make Observable instance methods available when using the datasource within a router. That worked since observables returned by route functions were converted to Rx5 internally. This change applies the same conversion to the observables returned by the unhandled data source methods.