Add flags for expensive path algorithms

Netflix / falcor

A JavaScript library for efficient data fetching

http://netflix.github.io/falcor

Apache License 2.0

10.49k stars 446 forks source link

Add flags for expensive path algorithms #962

Closed jcranendonk closed 5 years ago

jcranendonk commented 5 years ago

Added flags to disable request deduplication and path collapsing. These are expensive algorithms and we'd like to quantify their impact on users.

coveralls commented 5 years ago

Coverage increased (+0.02%) to 92.561% when pulling 36dfc03ac1980538e29bfe759dc0d8a0c4ea9145 on jcranendonk:feature_flags into 17db57d14ddf2c47519529a38b2e1d9c39c74e30 on Netflix:master.

asyncanup commented 5 years ago

just adding tests would be great, otherwise looks good!

asyncanup commented 5 years ago

Other than the minor nitpicks I made, looks good!