search

Netflix / flamescope

FlameScope is a visualization tool for exploring different time ranges as Flame Graphs.
Apache License 2.0
3k stars 168 forks source link

Use gzip python lib instead of guzip system bin #26

Closed takac closed 6 years ago

takac commented 6 years ago

Performance impact appears minimal

```
import timeit
print(timeit.timeit('calculate_stack_range("perf.stacks01")',
      setup='from app.util.stack import calculate_stack_range'))
print(timeit.timeit('read_offsets("perf.stacks01")',
      setup='from app.util.heatmap import read_offsets'))
```
spiermar commented 6 years ago

Thanks for the PR @takac

spiermar commented 6 years ago

gunzip is printing errors (but no exception) in the flame graph view.

gunzip: error writing to output: Broken pipe
gunzip: examples/stacks.perf_billing_01.txt.gz: uncompress failed

I'll have a look into this soon.

takac commented 6 years ago

I tested by running gzip gzip perf.stacks01then opening with flamescope, all workings fine with no errors. Could you provide an example for me to test with.

spiermar commented 6 years ago

@takac Just shared a link with you on Gitter