search

Netflix / flamescope

FlameScope is a visualization tool for exploring different time ranges as Flame Graphs.
Apache License 2.0
3k stars 168 forks source link

feat: support for DTrace stack profiles #56

Closed gmarler closed 5 years ago

gmarler commented 6 years ago

Wondering if this could be reviewed/refined and possibly folded in at some point.

Used named regex captures to allow perf, DTrace, and ultimately bcc profiles to be parsed.

Have provided an example DTrace profiling script, but can make it more generic as needed.

brendangregg commented 5 years ago

thanks, but I'm probably going to close this PR: there's over a dozen different profilers flamescope can support, and inserting code for each throughout flamescope will be a mess.

What flamescope should do is how I've architected flamegraph.pl: have it read a simple generic format, and then we write converters/modules for each. That isolates each profiler to its own file, and doesn't strew code throughout flamescope. At that point it should be even easier to add support for profilers like DTrace.

spiermar commented 5 years ago

Closing in favor of https://github.com/Netflix/flamescope/issues/69.