feat: icicle layout - Githubissues

Netflix / flamescope

FlameScope is a visualization tool for exploring different time ranges as Flame Graphs.

Apache License 2.0

3.02k stars 169 forks source link

feat: icicle layout #64

Closed bahtiyarkaba closed 5 years ago

bahtiyarkaba commented 5 years ago

This PR attempts to resolve #8 by adding a dropdown to select the layout of the flame-graph, with "flame" or "icicle" options.

The icicle layout is drawn by setting inverted on the flame graph.

Dropdown is chosen as it will also be useful for/in case sunburst layout #45 would be incorporated as well. I plainly put the control next to reset button. We might need some cosmetic tweaking if it looks ugly.

The chosen layout is stored to localstorage for persistence.

bahtiyarkaba commented 5 years ago

@spiermar I included the proposed changes. Could you review?

spiermar commented 5 years ago

@bahtiyarkaba will do

brendangregg commented 5 years ago

The d3 transition is really nice. Thanks!