Netflix / flamescope

FlameScope is a visualization tool for exploring different time ranges as Flame Graphs.
Apache License 2.0
3.02k stars 169 forks source link

master `Dockerfile` is broken #66

Closed nobeh closed 5 years ago

nobeh commented 5 years ago

Recent refactorings specifically b496f7787c52550fc3dc072ba538bcdc86f5e8d7 seems to have bumped the required Python from 2.7 to 3.6. In addition, libmagic is assumed to be installed for Python binding. These are not yet updated in Dockerfile; the following patch seems to fix the problem until a fix is merged:

diff --git a/Dockerfile b/Dockerfile
index e4c1346..23cba5c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,11 +1,12 @@
-FROM python:2-alpine3.7
+FROM python:3-alpine3.8

 ADD app /app/app
 ADD run.py /app
 ADD requirements.txt /app

-RUN cd /app && \
-  pip install -r requirements.txt && \
+RUN apk add libmagic && \
+  cd /app && \ \
+  pip3 install -r requirements.txt && \
   mkdir /profiles && \
   sed -i -e s/127.0.0.1/0.0.0.0/g -e s~examples~/profiles~g app/config.py

Side Note It would be great if there would be tags on the repo so that community could rely on a working version.

rahulsh1 commented 5 years ago

@nobeh There is a typo in your PR. cd /app && \ \ should be

cd /app && \

Otherwise it throws the misleading /bin/sh: : not found Thanks for providing a working version :+1:

Darkdoughnut commented 5 years ago

On macos I seem to have to add

cachetools==3.0.0

to requirements.txt to get this working.

spiermar commented 5 years ago

Yepp, forgot to add that recently. Will add shortly.