fix: flamegraph & differential_flame_graphs not working

Netflix / flamescope

FlameScope is a visualization tool for exploring different time ranges as Flame Graphs.

Apache License 2.0

3k stars 168 forks source link

fix: flamegraph & differential_flame_graphs not working #79

Closed ampresent closed 5 years ago

ampresent commented 5 years ago

This fix seems to work

spiermar commented 5 years ago

Issue was affecting flame graphs not generated from the newer nflxprofile, like perf. Need to change those to match the current minified format. Closing the PR since I already pushed the necessary changes in the last commit. HEAD should be working now. Thanks for looking into this.

ampresent commented 5 years ago

👍 And should I open a new PR containing only the last bugfix "fix: differential_flame_graph sign reversed" ?

spiermar commented 5 years ago

Oops, missed that bit. Sure. Tks