search

Netflix / genie

Distributed Big Data Orchestration Service
https://netflix.github.io/genie
Apache License 2.0
1.72k stars 369 forks source link

Fix gap in CPU resolution #1068

Closed tgianos closed 3 years ago

tgianos commented 3 years ago

The requested CPU was being dropped on the floor in favor of the default value (1) all the time. While this fix fixes that problem somewhat it doesn't address the fact that the resolved CPU value isn't persisted to the database as no field currently exists to save that. It would have to be done subsequently if we ever want to update the db schema.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1068 (c07bbb0) into master (20c3ad1) will decrease coverage by 0.05%. The diff coverage is 71.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1068      +/-   ##
============================================
- Coverage     90.97%   90.91%   -0.06%     
+ Complexity     3605     3603       -2     
============================================
  Files           451      451              
  Lines         13833    13863      +30     
  Branches        948      948              
============================================
+ Hits          12585    12604      +19     
- Misses          831      840       +9     
- Partials        417      419       +2
Impacted Files Coverage Δ Complexity Δ
...b/agent/launchers/impl/LocalAgentLauncherImpl.java 78.72% <57.81%> (-3.40%) 12.00 <2.00> (ø)
...b/agent/launchers/impl/TitusAgentLauncherImpl.java 96.55% <100.00%> (+0.12%) 8.00 <4.00> (ø)
...eb/apis/rest/v3/controllers/JobRestController.java 81.43% <100.00%> (ø) 48.00 <0.00> (ø)
...a/services/impl/jpa/JpaPersistenceServiceImpl.java 96.48% <100.00%> (ø) 232.00 <1.00> (ø)
.../genie/web/services/impl/JobLaunchServiceImpl.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...enie/web/services/impl/JobResolverServiceImpl.java 95.57% <100.00%> (+0.10%) 58.00 <1.00> (+1.00)
.../com/netflix/genie/agent/cli/HeartBeatCommand.java 87.50% <0.00%> (-6.25%) 4.00% <0.00%> (-2.00%)
...cution/services/impl/FetchingCacheServiceImpl.java 87.50% <0.00%> (-0.97%) 27.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20c3ad1...c07bbb0. Read the comment docs.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.004%) to 93.929% when pulling b757711c9374fd20cbad7f36637856ac00c801e7 on tgianos:GENIE-703 into 20c3ad1e2ce6dc94ccf854c3aa21bb46f01b6dd3 on Netflix:master.