Job Kill Logic improvements

[tgianos]

• Fix gaps in kill behavior between submission and launch which would cause runtime errors to be returned to clients and requests dropped on floor
• Add periodic janitorial process to clean up orphaned kill observers when agent connection migrates to different node or job completes
• Code formatting

[coveralls]

Coverage increased (+0.06%) to 93.931% when pulling 622e0a024c421cd3c6bf9d549f544b1da6999bfe on tgianos:GENIE-707 into 5d4ac8a4ab7d45d067e33907ece0c8fbe10523c3 on Netflix:master.

[codecov[bot]]

Codecov Report

Merging #1071 (622e0a0) into master (5d4ac8a) will increase coverage by 0.03%. The diff coverage is 91.97%.

@@             Coverage Diff              @@
##             master    #1071      +/-   ##
============================================
+ Coverage     90.90%   90.93%   +0.03%     
- Complexity     3608     3622      +14     
============================================
  Files           451      452       +1     
  Lines         13898    13962      +64     
  Branches        952      963      +11     
============================================
+ Hits          12634    12697      +63     
+ Misses          844      839       -5     
- Partials        420      426       +6     

Impacted Files	Coverage Δ	Complexity Δ
.../java/com/netflix/genie/agent/cli/ExecCommand.java	97.67% <ø> (ø)	16.00 <0.00> (ø)
...genie/common/external/dtos/v4/AgentJobRequest.java	100.00% <ø> (ø)	0.00 <0.00> (ø)
...flix/genie/common/external/dtos/v4/JobRequest.java	97.22% <ø> (ø)	13.00 <0.00> (ø)
...ernal/configs/CommonServicesAutoConfiguration.java	100.00% <ø> (ø)	8.00 <0.00> (ø)
...roperties/ExponentialBackOffTriggerProperties.java	100.00% <ø> (ø)	7.00 <0.00> (ø)
...rvices/impl/AgentRoutingServiceSingleNodeImpl.java	100.00% <ø> (ø)	8.00 <0.00> (ø)
...ring/autoconfigure/ZookeeperAutoConfiguration.java	100.00% <ø> (ø)	4.00 <0.00> (ø)
...ring/autoconfigure/data/DataAutoConfiguration.java	100.00% <ø> (ø)	4.00 <0.00> (ø)
.../java/com/netflix/genie/web/util/StreamBuffer.java	90.58% <ø> (ø)	16.00 <0.00> (ø)
...eb/apis/rest/v3/controllers/JobRestController.java	82.69% <80.00%> (+1.25%)	41.00 <1.00> (-7.00)	:arrow_up:
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d4ac8a...622e0a0. Read the comment docs.