Netflix / genie

Distributed Big Data Orchestration Service
https://netflix.github.io/genie
Apache License 2.0
1.71k stars 367 forks source link

Add missing fields to Titus launcher #1073

Closed tgianos closed 3 years ago

tgianos commented 3 years ago

Also make additional properties dynamic to improve rollout flexibility

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.007%) to 93.938% when pulling 87823a4e8c0a02680c6aab72e3ad8569aa06d2fd on tgianos:GENIE-566 into 2845660e0c8a1ba24ad062123029f7f2f47509f2 on Netflix:master.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1073 (87823a4) into master (2845660) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1073      +/-   ##
============================================
+ Coverage     90.94%   90.95%   +0.01%     
- Complexity     3623     3625       +2     
============================================
  Files           452      452              
  Lines         13962    13978      +16     
  Branches        963      963              
============================================
+ Hits          12698    12714      +16     
  Misses          839      839              
  Partials        425      425              
Impacted Files Coverage Δ Complexity Δ
...b/agent/launchers/impl/TitusAgentLauncherImpl.java 91.79% <100.00%> (+0.73%) 10.00 <0.00> (ø)
...m/netflix/genie/web/dtos/TitusBatchJobRequest.java 79.24% <100.00%> (+0.39%) 8.00 <0.00> (ø)
...e/web/properties/TitusAgentLauncherProperties.java 100.00% <100.00%> (ø) 32.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2845660...87823a4. Read the comment docs.