search

Netflix / genie

Distributed Big Data Orchestration Service
https://netflix.github.io/genie
Apache License 2.0
1.71k stars 367 forks source link

Fix search by tag count queries for commands, clusters and applications #1162

Closed tgianos closed 2 years ago

tgianos commented 2 years ago

Searching by tags for these entites results in a query using group by and having. This was working fine for the actual content queries but the count queries were getting messed up because it couldn't count the result properly as it was just and array of 1's being return (counting the group size and all were one). It was actually the length of the result set we'd have wanted for the total count. This wouldn't work though for the ones were tags weren't involved because that query doesn't have a group by and a having.

This change modifies the count queries to instead of trying to count directly with the same where predicate it actually counts the results of the real query as a subquery (all on database side so it doesn't return all the data). This way it doesn't matter if there's a group by or not. Now the total results returned via the API in the Page object are correct and pagination can continue properly.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.07%) to 93.876% when pulling bdb6a3af931ae826e575ab75fec01b396fd24470 on tgianos:entitySearchByTags into 51b81edcf4e63b0b667441a75d836d414380fdb7 on Netflix:master.