search

Netflix / governator

Governator is a library of extensions and utilities that enhance Google Guice to provide: classpath scanning and automatic binding, lifecycle management, configuration to field mapping, field validation and parallelized object warmup.
Apache License 2.0
825 stars 180 forks source link

Add Javax dep for Java 11 #397

Closed carl-mastrangelo closed 5 years ago

carl-mastrangelo commented 5 years ago

Hi, this is needed to upgrade Netflix/zuul to Java 11. The jar being added in was factored out of Java8 and into a separate package, thus the need to include the dep.

qiangdavidliu commented 5 years ago

@carl-mastrangelo do you mind re pushing your two PRs? They are both failing on the builder JDK. The change to openJDK should fix that. Thanks.

carl-mastrangelo commented 5 years ago

@qiangdavidliu done PTAL.

Also as a side note, governator-test didn't compile for me. The gradle file is missing several of the dependencies.

qiangdavidliu commented 5 years ago

@asibross

carl-mastrangelo commented 5 years ago

cc: @artgon

carl-mastrangelo commented 5 years ago

Friendly ping, anything more to do here?

carl-mastrangelo commented 5 years ago

FYI I updated a few more things to work with Java 11. These should be pretty minor. I confirmed this builds with both Java 11 and Java 8.

PTAL. Also, I don't know what procedure is for merging, I assume you merge after you approve.

asibross commented 5 years ago

Changes are covered by #400