Netflix / hubcommander

A Slack bot for GitHub organization management -- and other things too

Apache License 2.0

1.28k stars 156 forks source link

Add thread support #65

Closed sgedward closed 6 years ago

sgedward commented 6 years ago

55

Change: slack_comm.py

mikegrima commented 6 years ago

Hello @sgedward. Would prefer not making use of globals.

I think this would be best accomplished by having a function to return a timestamp, and having thread sent in via a keyword arg to the say* functions.

I think an approach similar to #63 would best implement this feature.

sgedward commented 6 years ago

@mikegrima thanks for leting me know. fixed

mikegrima commented 6 years ago

Testing this today

mikegrima commented 6 years ago

@sgedward slight merge conflict that should be very easy to fix.

mikegrima commented 6 years ago

I'll fix the conflict -- some changes I need to make to incorporate this PR with the ephemeral messages one.