search

Netflix / lemur

Repository for the Lemur Certificate Manager
Apache License 2.0
1.73k stars 322 forks source link

Improvement offer: ADCS issuer plugin #2179

Closed sirferl closed 5 years ago

sirferl commented 6 years ago

Hello, I implemented a ADCS issuer plugin to interact with Microsofts AD Certificate Services. It uses certsrv as a base. If it is of interest for this project, I am willing to share it. Since I have no experience with github I need some guidance how to proper integrate this. regards sireferl

castrapel commented 5 years ago

Hi @sirferl, sure that would be super useful for others. I'd recommend following a workflow like this: https://yangsu.github.io/pull-request-tutorial/ , and submitting a pull request. I'd be happy to help you out as well. please let me know what issues you run in to.

The jist: Create a new branch, commit code to that branch, push to that branch, and within github web UI you should have the option to create a PR.

sirferl commented 5 years ago

Ok, I'll give it a try.