Remove quartz dependency

varunu28 commented 3 months ago

Pull Request type

[ ] Bugfix
[ ] Feature
[X] Refactoring (no functional changes, no api changes)
[X] Build related changes (Please run ./gradlew build --write-locks to refresh dependencies)
[ ] Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

This fixes #11 to remove the quartz dependency

Remove dependency on quartz
Refactor cron creation flow to use Cron instead of CronExpression
Impact of this change is that cron creation with a timezone is not possible but the execution time for the cron can be calculated using nextExecutionTime by providing a timezone.

varunu28 commented 3 months ago

@jun-he Please do a round of review whenever you get a chance? I am open to feedback on how can we support cron creation along with timezone during the creation operation.

jun-he commented 3 months ago

@varunu28 thanks for the contribution. Will review it soon.

jun-he commented 3 months ago

@varunu28 can you rebase your change?

varunu28 commented 3 months ago

@varunu28 can you rebase your change?

Done

varunu28 commented 3 months ago

@jun-he Bump on this for review. Thanks 👍

jun-he commented 3 months ago

@varunu28 Will review it soon.

Netflix / maestro

Remove quartz dependency #31

Pull Request type

Changes in this PR