Netflix / mantis

A platform that makes it easy for developers to build realtime, cost-effective, operations-focused applications
Apache License 2.0
1.42k stars 202 forks source link

Fix compile warnings in mantis-connector-iceberg module #395

Open liuml07 opened 1 year ago

liuml07 commented 1 year ago

There are compile warnings in the code due to:

We don't need to solve all of them, but a good coding exercise is to address most those compile warnings when possible. Guidelines are:

  1. Not change code logic, which should be addressed and filed PR separately
  2. Not change public interfaces (class, methods and fields) that would break other modules or applications. But it's safe to rename private fields or methods when necessary.
  3. Prefer readability to more concise code
  4. Improve tests in the module is welcome but not required
  5. Compile and pass all existing tests.

This tracks the effort for the mantis-connector-iceberg module to make the code change scoped.

SalmaAfifi commented 1 year ago

Hi @liuml07 can you please assign this task to me?

liuml07 commented 1 year ago

Sounds good! Thanks for taking this up.