unnecessary type parameters (like Map<String> m = new HashMap<String>())
anonymous class can be replaced with lambdas
... and more.
We don't need to solve all of them, but a good coding exercise is to address most those compile warnings when possible. Guidelines are:
Not change code logic, which should be addressed and filed PR separately
Not change public interfaces (class, methods and fields) that would break other modules or applications. But it's safe to rename private fields or methods when necessary.
Prefer readability to more concise code
Improve tests in the module is welcome but not required
Compile and pass all existing tests.
This tracks the effort for the mantis-connector-iceberg module to make the code change scoped.
There are compile warnings in the code due to:
@Nullable/@NotNull
annotationsMap<String> m = new HashMap<String>()
)We don't need to solve all of them, but a good coding exercise is to address most those compile warnings when possible. Guidelines are:
This tracks the effort for the
mantis-connector-iceberg
module to make the code change scoped.