Netflix / mantis

A platform that makes it easy for developers to build realtime, cost-effective, operations-focused applications
Apache License 2.0
1.42k stars 202 forks source link

Ensure Master Monitor Can Read Lock ByteBuffer More than Once #686

Closed kmg-stripe closed 4 months ago

kmg-stripe commented 4 months ago

It is possible that the DynamoDBMasterMonitor checks for the current leader more often than the underlying ByteBuffer is updated by the DynamoDB library. In this case, we should rewind the buffer.

We can also optionally create a separate config for the lock client update and the monitor check leader interval to ensure check leader is called less frequently than the lock client updates.

Context

Explain context and other details for this pull request.

Checklist

github-actions[bot] commented 4 months ago

Test Results

534 tests  ±0   528 :white_check_mark: ±0   7m 50s :stopwatch: -1s 139 suites ±0     6 :zzz: ±0  139 files   ±0     0 :x: ±0 

Results for commit 5b486e6d. ± Comparison against base commit 2c5bfd4e.

:recycle: This comment has been updated with latest results.