Netflix / mantis

A platform that makes it easy for developers to build realtime, cost-effective, operations-focused applications
Apache License 2.0
1.42k stars 202 forks source link

DynamoDB Leader Monitor: On Next Should Always Provide MasterDescription #691

Closed kmg-stripe closed 4 months ago

kmg-stripe commented 4 months ago

It appears that specifying null to the observer results in a weird terminal condition where all values after null are not observed.

ToDo(kmg): Need to verify this and create or add to the unit tests.

Context

Explain context and other details for this pull request.

Checklist

github-actions[bot] commented 4 months ago

Test Results

534 tests  ±0   528 :white_check_mark: ±0   7m 52s :stopwatch: -5s 139 suites ±0     6 :zzz: ±0  139 files   ±0     0 :x: ±0 

Results for commit 09105a00. ± Comparison against base commit 10c1dd89.

crioux-stripe commented 4 months ago

Closing in favor of https://github.com/Netflix/mantis/pull/692