Fix WorkersByJobId: Filtered Workers Not Empty Check

Netflix / mantis

A platform that makes it easy for developers to build realtime, cost-effective, operations-focused applications

Apache License 2.0

1.42k stars 202 forks source link

Fix WorkersByJobId: Filtered Workers Not Empty Check #699

Closed kmg-stripe closed 3 months ago

kmg-stripe commented 3 months ago

Context

I forgot to update the previous PR with this fix. We have enough cruft lying around from all of the churn, that we hit cases where we get a NPE when we cannot parse the worker payload in getAllWorkersByJobId. This checks to ensure workers is not empty before referencing the first element of workers.

Checklist

[X] ./gradlew build compiles code correctly
[ ] Added new tests where applicable
[X] ./gradlew test passes all tests
[ ] Extended README or added javadocs where applicable

github-actions[bot] commented 3 months ago

Test Results

537 tests +214 531 :white_check_mark: +214 7m 46s :stopwatch: + 1m 4s 139 suites + 44 6 :zzz: ± 0 139 files + 44 0 :x: ± 0

Results for commit 43f1c11a. ± Comparison against base commit ef3ad829.

:recycle: This comment has been updated with latest results.

kmg-stripe commented 3 months ago

@hmitnflx - If you have a sec, could you have a look at this one? Should be quick.

crioux-stripe commented 3 months ago

@Andyz26 Hey! One more for our production readiness if you don't mind.

crioux-stripe commented 3 months ago

@Andyz26 Sorry about self-approving on this one. I wanted to make sure @kmg-stripe could hit our target of releasing today.

Andyz26 commented 3 months ago

@crioux-stripe no worries. I am on vacation and I will check with @hmit on this.