Closed queueburt closed 4 years ago
I'm feeling like I no longer like the idea of a separate CFN template in this PR to incorporate Step Functions in a standalone way. The only users it helps are manual deployers who suddenly want to use CFN for Step Functions, and it means we would now have two places to maintain parity for new features. @savingoyal I think I'm going to remove metaflow-cfn-ONLY-stepfunctions.yml from this PR (because if I don't I have to make a bunch of adjustments to support DB migration), but I wanted to float it out to the larger team before I do.
@queueburt Yes, let's remove metaflow-cfn-ONLY-stepfunctions.yml
I just deployed the stack via CF, and it deploys just fine :) I haven't tested the SF functionality though.
Final update: health-check port for the new traffic flow has been changed to 8080, and is passing in my test deployments. I'm comfortable calling this good-for-merge assuming some +1 love from @savingoyal @tobias-gp @ferras and @tuulos
Changes to metaflow-cfn-template.yml:
Role and policy additions:
Infrastructure Additions:
Fixes:
Addition of metaflow-cfn-ONLY-stepfunctions.yml: