search

Netflix / metaflow

Open Source Platform for developing, scaling and deploying serious ML, AI, and data science systems
https://metaflow.org
Apache License 2.0
8.26k stars 774 forks source link

enhance the functionality of _update_env #1969

Closed madhur-ob closed 2 months ago

madhur-ob commented 3 months ago

@romain-intel this is nothing but a copy of what we do for _enrich_object in Deployer.. i.e. https://github.com/Netflix/metaflow/blob/af8fade5921dbe10c1872e34db1643241241ee72/metaflow/runner/deployer.py#L192

it allows us to insert parametrised functions as well instead of just static pre-calculated properties..

romain-intel commented 2 months ago

I get that @madhur-ob -- it's just that current has particular semantics and adding functiosn to it somewhat expands/breaks it so want to make sure we think carefully about it instead of just adding it. I don't question the technical aspect of it but just don't understand the specific use case for it nor how it plays with the other functions that are there.

savingoyal commented 2 months ago

@madhur-ob how about we introduce current.snowflake.session() instead?