Netflix / metaflow

Open Source Platform for developing, scaling and deploying serious ML, AI, and data science systems
https://metaflow.org
Apache License 2.0
8.28k stars 774 forks source link

Docstring for AwsSecretsManagerSecretsProvider is incorrect #2089

Open dendraR2 opened 1 month ago

dendraR2 commented 1 month ago

The docstring for class AwsSecretsManagerSecretsProvider(SecretsProvider) says

 If the secret contains a string payload ("SecretString"):
        - if the `parse_secret_string_as_json` option is True (default):
            {SecretString} will be parsed as a JSON. If successfully parsed, AND the JSON contains a
            top-level object, each entry K/V in the object will also be converted to an entry in the result. V will
            always be casted to a string (if not already a string).
        - If `parse_secret_string_as_json` option is False:
            {SecretString} will be returned as a single entry in the result, with the key being the secret_id.

aws_secrets_manager_secrets_provider.py

Looking down the code the actual option for this should just be json rather than parse_secret_string_as_json

savingoyal commented 1 month ago

thanks for the issue! would you like to contribute a PR?