search

Netflix / msl

Message Security Layer
Apache License 2.0
716 stars 79 forks source link

Allow MessageBuilder, MessageHeader and ErrorHeader to be subclassed. #281

Closed aliddeke closed 6 years ago

aliddeke commented 6 years ago

That's a mistake, looks like I was a bit greedy in my 'streamFactory' string replacement and added that one by accident, I'll fix this.

On Mon, Aug 27, 2018 at 5:12 PM, Paul Adolph notifications@github.com wrote:

@padolph commented on this pull request.

In core/src/main/java/com/netflix/msl/msg/MslControl.java https://github.com/Netflix/msl/pull/281#discussion_r213152327:

  * or outgoing messages. The filters will be placed between the MSL message
  • and MSL control, meaning they will see the actual MSL message data as it
  • is being read from or written to the remote entity.
    • @param factory filter stream factory. May be null.
    • @param factory filter message factory. May be null. */ public void setFilterFactory(final FilterStreamFactory factory) {

factory is type is FilterStreamFactory, but comment was changed to say "filter message factory". Should you also rename the FilterStreamFactory Type?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Netflix/msl/pull/281#pullrequestreview-149928140, or mute the thread https://github.com/notifications/unsubscribe-auth/ATkww5oyFjpwgJpm6Du3-SOvBFBCJ4qmks5uVIr4gaJpZM4WOmJr .