search

Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
234 stars 76 forks source link

Incorrect version number (always 4.6.0-SNAPSHOT) #225

Closed stevn closed 5 years ago

stevn commented 5 years ago

When analyzing an IMP, the Photon version number is appended to the log output. But it is always:

[Photon version: 4.6.0-SNAPSHOT]

Even when I actually built the v4.5.13 release.

It seems like "build/manifestPhoton.properties" file should be adjusted for every new release:

Implementation-Title=com.netflix.photon#Photon;4.6.0-SNAPSHOT
Implementation-Version=4.6.0-SNAPSHOT

Related to #170

stevn commented 5 years ago

I found this to work:

./gradlew -Prelease.useLastTag=true build

Maybe this should be mentioned in the README?