Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
234 stars 76 forks source link

Do you think we can support a list of application here (splitted via comma): #242

Open IMFTool opened 5 years ago

IMFTool commented 5 years ago

Do you think we can support a list of application here (splitted via comma): --applications app2,app5 because with next application it will become complexe to add all combination (I have submitted to support TSP 2121-1, TSP 2121-4 can come this year and App4 too).

So internally we can have an array of ApplicationCompositionType. What do you think ?

Originally posted by @MarcAntoine-Arnaud in https://github.com/Netflix/photon/pull/238

IMFTool commented 5 years ago

What would be the expected behaviour when you specify "--applications app2,app5"?

MarcAntoine-Arnaud commented 5 years ago

Photon will check the compliancy of any package compatible with App2 or App5 (no App2e here). --applications app2,app2e,app5 will check for App2, App2e, and App5.

It will just change these line of code: https://github.com/wruppelx/photon/blob/master/src/main/java/com/netflix/imflibrary/app/IMPAnalyzer.java#L644

IMFTool commented 5 years ago

The default behaviour is to check against the application specified in ApplicationIdentification of a given CPL. Please note that the --application option proposed by #238 is optional. --application is meant to force Photon to test against a specific application. The list of permitted parameters for --application can be extended as more IMF Applications are supported. I have modified the list of parameters to be app2, app2E or app5. Does that make sense?

palemieux commented 5 years ago

--applications app2,app5

I do not see a clear use case for this since app2 and app5 are mutually exclusive, unless the validation against each app is applied successively, in which, why not simply run the validator multiple times.

There is probably a case for a --plugins plugin1-uri, plugin2-uri, since multiple plugins can be applied to a single application.

cconcolato commented 5 years ago

Note that this issue is related to #218 and should be taken into account.