search

Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
234 stars 76 forks source link

Feature/imp fixer analyzer usage #254

Closed tcase-netflix closed 5 months ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #254 into master will increase coverage by 2.81%. The diff coverage is 68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #254      +/-   ##
============================================
+ Coverage     66.87%   69.69%   +2.81%     
- Complexity     1493     1563      +70     
============================================
  Files           154      154              
  Lines         10773    10792      +19     
  Branches       1595     1603       +8     
============================================
+ Hits           7204     7521     +317     
+ Misses         2800     2480     -320     
- Partials        769      791      +22
Impacted Files Coverage Δ Complexity Δ
...n/java/com/netflix/imflibrary/app/IMPAnalyzer.java 74.78% <100%> (+26.55%) 56 <5> (+27) :arrow_up:
...netflix/imflibrary/app/IMFTrackFileCPLBuilder.java 83.48% <31.81%> (+23.3%) 22 <0> (+6) :arrow_up:
...main/java/com/netflix/imflibrary/app/IMPFixer.java 69.5% <68.96%> (+69.5%) 29 <0> (+29) :arrow_up:
...brary/st2067_2/AbstractApplicationComposition.java 76.82% <0%> (+0.24%) 88% <0%> (+1%) :arrow_up:
...brary/st2067_2/CompositionModel_st2067_2_2016.java 78.63% <0%> (+0.85%) 17% <0%> (+1%) :arrow_up:
...lix/imflibrary/RESTfulInterfaces/IMPValidator.java 48.82% <0%> (+1.4%) 52% <0%> (+2%) :arrow_up:
.../main/java/com/netflix/imflibrary/Colorimetry.java 94.81% <0%> (+1.48%) 9% <0%> (+1%) :arrow_up:
...com/netflix/imflibrary/app/IMFTrackFileReader.java 53.96% <0%> (+2.13%) 43% <0%> (+1%) :arrow_up:
...netflix/imflibrary/writerTools/utils/IMFUtils.java 64.51% <0%> (+4.83%) 8% <0%> (+1%) :arrow_up:
...java/com/netflix/imflibrary/utils/ErrorLogger.java 81.48% <0%> (+7.4%) 0% <0%> (ø) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7fe6f6d...a1c71be. Read the comment docs.

tcase-netflix commented 5 years ago

FYI @IMFTool & @MarcAntoine-Arnaud - let me know if you have objections to this change.

IMFTool commented 5 years ago

Works on my end. But from the usability point of view, I see a slight risk users will associate the exceptions thrown for analysis errors with an irregular termination of Photon as opposed to an issue with the IMP under test.