search

Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
234 stars 76 forks source link

Fix IMP Builders when marker tracks are used #262

Closed davidt-netflix closed 4 years ago

davidt-netflix commented 4 years ago

Fixes #261 Previously, several of the IMP Builder classes would throw exceptions if a marker track was used (instead of an essence track). This PR fixes the casting exceptions, and adds basic support for including marker tracks when building an IMP.

codecov[bot] commented 4 years ago

Codecov Report

Merging #262 into master will increase coverage by 0.21%. The diff coverage is 90.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #262      +/-   ##
============================================
+ Coverage     67.64%   67.86%   +0.21%     
- Complexity     1588     1609      +21     
============================================
  Files           158      158              
  Lines         11158    11226      +68     
  Branches       1686     1701      +15     
============================================
+ Hits           7548     7618      +70     
+ Misses         2799     2798       -1     
+ Partials        811      810       -1
Impacted Files Coverage Δ Complexity Δ
...com/netflix/imflibrary/writerTools/IMPBuilder.java 81.66% <100%> (+1.46%) 27 <0> (+3) :arrow_up:
...y/writerTools/CompositionPlaylistBuilder_2013.java 77.09% <90.69%> (+1.99%) 29 <3> (+7) :arrow_up:
...y/writerTools/CompositionPlaylistBuilder_2016.java 80.23% <90.69%> (+2.05%) 31 <3> (+8) :arrow_up:
...brary/st2067_2/CompositionModel_st2067_2_2016.java 78.63% <0%> (+0.85%) 17% <0%> (+1%) :arrow_up:
...brary/st2067_2/CompositionModel_st2067_2_2013.java 76.1% <0%> (+0.88%) 19% <0%> (+1%) :arrow_up:
...com/netflix/imflibrary/st2067_2/IMFMarkerType.java 84.61% <0%> (+3.84%) 5% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 415759d...9dad04f. Read the comment docs.