search

Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
234 stars 76 forks source link

Support TSP App 2121-1 #263

Open MarcAntoine-Arnaud opened 4 years ago

MarcAntoine-Arnaud commented 4 years ago

update of #234

codecov[bot] commented 4 years ago

Codecov Report

Merging #263 into master will decrease coverage by 1.31%. The diff coverage is 2.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
- Coverage     67.86%   66.54%   -1.32%     
  Complexity     1609     1609              
============================================
  Files           158      160       +2     
  Lines         11226    11457     +231     
  Branches       1701     1742      +41     
============================================
+ Hits           7618     7624       +6     
- Misses         2798     3023     +225     
  Partials        810      810
Impacted Files Coverage Δ Complexity Δ
...mflibrary/st2067_2/IMFCompositionPlaylistType.java 65.14% <ø> (ø) 25 <0> (ø) :arrow_down:
...brary/st2067_2/AbstractApplicationComposition.java 76.99% <ø> (ø) 89 <0> (ø) :arrow_down:
...ibrary/tsp_2121/ApplicationTsp2121Composition.java 0% <0%> (ø) 0 <0> (?)
...CompositionImageEssenceTsp2121DescriptorModel.java 0% <0%> (ø) 0 <0> (?)
...2067_2/CompositionImageEssenceDescriptorModel.java 73.42% <0%> (-0.64%) 91 <0> (ø)
.../main/java/com/netflix/imflibrary/Colorimetry.java 93.43% <100%> (+0.09%) 8 <0> (ø) :arrow_down:
...ibrary/st2067_2/ApplicationCompositionFactory.java 90.76% <100%> (+0.6%) 7 <0> (ø) :arrow_down:
...in/java/com/netflix/imflibrary/IMFConstraints.java 41.56% <0%> (-1.83%) 26% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d646f2...a030997. Read the comment docs.

MarcAntoine-Arnaud commented 4 years ago

Hi @cconcolato, Do you have time to check it soon ?

Best, Marc-Antoine

robjay commented 4 years ago

Hi, is there an ETA of this being released? I noticed that photon now supports application 5, but App 2121-1 is still waiting to be merged and released.

MarcAntoine-Arnaud commented 4 years ago

@cconcolato do you have a little bit of time ? Thanks

robjay commented 4 years ago

@MarcAntoine-Arnaud, will you be extending this to support TSP 2121-4 ?

cconcolato commented 4 years ago

Could you add a test file that exercises the code you added? Code coverage is at 0% for ApplicationTsp2121Composition.java.