search

Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
234 stars 76 forks source link

App5 ACES: ContainerConstraintsSubDescriptor check added, test files update #270

Closed IMFTool closed 4 years ago

IMFTool commented 4 years ago

ST 2065-5 references ST 379-2 (Constrained Generic Container), which requires a ContainerConstraintsSubDescriptor to be present. This PR checks App5 ACES packages for the presence of the ContainerConstraintsSubDescriptor in 2065-5 track files, and issues a warning if is not present. A new related test case has been added, the existing test cases were updated. Note: The recent asdcplib version generates the ContainerConstraintsSubDescriptor for ACES track files.

codecov[bot] commented 4 years ago

Codecov Report

Merging #270 into master will decrease coverage by 0.19%. The diff coverage is 26.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #270     +/-   ##
===========================================
- Coverage     67.86%   67.66%   -0.2%     
- Complexity     1609     1613      +4     
===========================================
  Files           158      159      +1     
  Lines         11226    11278     +52     
  Branches       1701     1710      +9     
===========================================
+ Hits           7618     7631     +13     
- Misses         2798     2836     +38     
- Partials        810      811      +1
Impacted Files Coverage Δ Complexity Δ
...tflix/imflibrary/st2067_100/OutputProfileList.java 70.27% <ø> (ø) 41 <0> (ø) :arrow_down:
...ix/imflibrary/st2067_201/IABEssenceDescriptor.java 68.42% <ø> (ø) 3 <0> (ø) :arrow_down:
...etflix/imflibrary/st0377/header/SubDescriptor.java 100% <ø> (ø) 1 <0> (ø) :arrow_down:
...st0377/header/GenericPictureEssenceDescriptor.java 95.83% <ø> (ø) 1 <0> (ø) :arrow_down:
...y/st0377/header/GenericSoundEssenceDescriptor.java 68.75% <ø> (ø) 12 <0> (ø) :arrow_down:
...com/netflix/imflibrary/st0377/HeaderPartition.java 76.93% <0%> (-1.42%) 126 <0> (ø)
...in/java/com/netflix/imflibrary/IMFConstraints.java 41.56% <0%> (-1.83%) 26 <0> (ø)
...ry/st2067_201/IABSoundfieldLabelSubDescriptor.java 30.3% <0%> (-0.95%) 2 <0> (ø)
...x/imflibrary/st0377/header/StructuralMetadata.java 89.82% <100%> (+0.02%) 35 <0> (+1) :arrow_up:
...2067_2/CompositionImageEssenceDescriptorModel.java 74.35% <100%> (+0.29%) 92 <0> (+1) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f8cadb...86678c8. Read the comment docs.