Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
234 stars 76 forks source link

Incorrect maximum Marker offset constraint #273

Open palemieux opened 4 years ago

palemieux commented 4 years ago

Per subclause 6.13 at SMPTE ST 2067-3:

The native duration of a MarkerResourceType instance, as indicated by the IntrinsicDuration element, shall be set to any value equal or larger to the largest Offset value within all its Marker elements.

The following incorrectly emits an error when the Marker offset is equal to the IntrinsicDuration:

https://github.com/Netflix/photon/blob/415759d40989946b9b467f0ce6bb06b83bb6685b/src/main/java/com/netflix/imflibrary/st2067_2/IMFCoreConstraintsChecker.java#L418

Sample CPL