search

Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
237 stars 77 forks source link

Fix IAB Track Duration #275

Closed davidt-netflix closed 4 years ago

davidt-netflix commented 4 years ago

Fixed a bug where IAB tracks were returning zero duration. Duration logic is no longer conditional to the Sequence type. Only TrackFileResource sequences are currently supported. Other subtypes may require more specialized logic.

codecov[bot] commented 4 years ago

Codecov Report

Merging #275 into master will decrease coverage by 0.00%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #275      +/-   ##
============================================
- Coverage     67.63%   67.62%   -0.01%     
  Complexity     1657     1657              
============================================
  Files           166      166              
  Lines         11568    11566       -2     
  Branches       1751     1750       -1     
============================================
- Hits           7824     7822       -2     
  Misses         2913     2913              
  Partials        831      831
Impacted Files Coverage Δ Complexity Δ
...a/com/netflix/imflibrary/st2067_2/Composition.java 66.16% <66.66%> (-0.34%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bdc3c4...ea92c29. Read the comment docs.