search

Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
237 stars 77 forks source link

Fixed a build error when .git directory is missing #278

Closed davidt-netflix closed 4 years ago

davidt-netflix commented 4 years ago

The problem occurs when there is no '.git' directory, such as when using the 'Download Zip' button from GitHub instead of 'git clone'. To workaround, this required renaming the 'config' directory to 'codequality' instead.

The root cause of this, is a bug in JGit, which is used by the Nebula plugin. The gradle plugin attempts to find a configuration file, and incorrectly attempts to load the 'config' directory as a file. This bug is specific to the name 'config'.

codecov[bot] commented 4 years ago

Codecov Report

Merging #278 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #278   +/-   ##
=========================================
  Coverage     67.95%   67.95%           
  Complexity     1688     1688           
=========================================
  Files           166      166           
  Lines         11546    11546           
  Branches       1731     1731           
=========================================
  Hits           7846     7846           
  Misses         2884     2884           
  Partials        816      816

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95d2d39...3c43cc9. Read the comment docs.