search

Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
237 stars 77 forks source link

Add APP2.HT.REV and APP2.HT.IRV constraint sets validation #368

Closed palemieux closed 1 month ago

palemieux commented 3 months ago

Closes #370

Validate the CPL essence descriptors against the APP2.HT.REV and APP2.HT.IRV constraint sets specified in ST 2067-21, Annex I.

The PR imposes constraints on the B parameter as suggested at https://github.com/SMPTE/st2067-21/issues/7

To be finalized following the June 26, 2024 IMF plugfest.

davidt-netflix commented 3 months ago

Looks good to me. 👍 I left several comments about minor changes, or code style. But I don't see any major issues. You did a really good job of adding validations for pretty much every constraint in Annex I.

I'll let you consider some of the comments, and give everyone else a chance to review the PR as well. But otherwise I'll plan to mark it approved, and merge in the next few days, whenever you are ready.

fschleich commented 1 month ago

PR replaced by PR #375 (merged)