Include slf4j "simple" binding/provider as a runtime dependency

Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013

Apache License 2.0

237 stars 77 forks source link

Include slf4j "simple" binding/provider as a runtime dependency #371

Closed thomasheritage closed 1 month ago

thomasheritage commented 3 months ago

A logging provider needs to be specified when running the Photon applications from the commandline (e.g. com.netflix.imflibrary.app.IMPAnalyzer) -- otherwise there is an error per #366

However, is this inappropriate for other ways of running Photon? (e.g. as a library) If so, perhaps this dependency could be moved to a new Gradle "dependency configuration" that can be selected specifically when running Photon applications from the commandline?

Closes #366

thomasheritage commented 3 months ago

Related to #349

fschleich commented 1 month ago

Thanks - this has been addressed via #375

slf4j is also needed for compilation in test, so this has been declared as implementation dependency

thomasheritage commented 1 month ago

Thanks @fschleich for resolving this