Netflix / photon

Photon is a Java implementation of the Interoperable Master Format (IMF) standard. IMF is a SMPTE standard whose core constraints are defined in the specification st2067-2:2013
Apache License 2.0
234 stars 76 forks source link

Handle MXF string termination to avoid incorrect validation errors #372

Open thomasheritage opened 1 week ago

thomasheritage commented 1 week ago

MXF Header Metadata string properties that contain a null character should be trimmed. Currently, the terminating null character (and any subsequent characters) are included in the string used by Photon for validation, resulting in incorrect error reports such as:

[main] ERROR com.netflix.imflibrary.app.IMPAnalyzer -           ERROR-Language Code ([0x656e2d474200, en-GB.]) in SoundFieldGroupLabelSubdescriptor in the IMFTrackfile represented by ID ac4aaec3-a55c-48d0-a806-6cb92888ab3a is not RFC5646 compliant [Photon version: 4.10.0-SNAPSHOT]
thomasheritage commented 1 week ago

This looks like the same as was discussed in #196 (which is closed)