Netflix / ribbon

Ribbon is a Inter Process Communication (remote procedure calls) library with built in software load balancers. The primary usage model involves REST calls with various serialization scheme support.
Apache License 2.0
4.58k stars 1.24k forks source link

NFHttpClient uses deprecated MaxHttpConnectionsPerHost for connection pool size #320

Open WeipingGuo opened 7 years ago

WeipingGuo commented 7 years ago

Looks like NFHttpClient is still uses MaxHttpConnectionsPerHost for the connection pool size even though the property is deprecated by MaxConnectionsPerHost.

https://github.com/Netflix/ribbon/blob/5e6066dd63253014599b4fd89713a7b51f19d165/ribbon-httpclient/src/main/java/com/netflix/http4/NFHttpClient.java#L165

https://github.com/Netflix/ribbon/blob/5e6066dd63253014599b4fd89713a7b51f19d165/ribbon-core/src/main/java/com/netflix/client/config/CommonClientConfigKey.java#L83

Related issue: https://github.com/spring-cloud/spring-cloud-netflix/issues/1466

Thanks Weiping

Hyunk3l commented 7 years ago

+1