search

Netflix / ribbon

Ribbon is a Inter Process Communication (remote procedure calls) library with built in software load balancers. The primary usage model involves REST calls with various serialization scheme support.
Apache License 2.0
4.56k stars 1.24k forks source link

id 'nebula.netflixoss' version '2.2.10' error #332

Open lorgine-li opened 7 years ago

lorgine-li commented 7 years ago

when i build ribbon and print

BUILD FAILED

and my env is jdk 1.8 and the gradle.build is: plugins { id 'nebula.netflixoss' version '2.2.10' }

// Establish version and status ext.githubProjectName = rootProject.name // Change if github project name is not the same as the root project's name

subprojects { apply plugin: 'nebula.netflixoss' apply plugin: 'java'

sourceCompatibility = 1.7
targetCompatibility = 1.7

group = "com.netflix.${githubProjectName}" // TEMPLATE: Set to organization of project

repositories {
    jcenter()
}

if (project.hasProperty('useMavenLocal')) {
    repositories {
        mavenLocal()
    }
}
if (project.getProperty('status').equals("snapshot")) {
    repositories {
        maven { url 'http://oss.jfrog.org/oss-snapshot-local' }
    }
}

}

rspieldenner commented 7 years ago

The plugin requires a git repo to calculate version On Fri, Mar 17, 2017 at 4:42 AM lorgine notifications@github.com wrote:

when i build ribbon and print

  • What went wrong: An exception occurred applying plugin request [id: 'nebula.netflixoss', version: '2.2.10']

repository not found: C:\Users\lichengsheng\Downloads\ribbon-master\ribbon-master

  • Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

and my env is jdk 1.8 and the gradle.build is: plugins { id 'nebula.netflixoss' version '2.2.10' }

// Establish version and status ext.githubProjectName = rootProject.name // Change if github project name is not the same as the root project's name

subprojects { apply plugin: 'nebula.netflixoss' apply plugin: 'java'

sourceCompatibility = 1.7 targetCompatibility = 1.7

group = "com.netflix.${githubProjectName}" // TEMPLATE: Set to organization of project

repositories { jcenter() }

if (project.hasProperty('useMavenLocal')) { repositories { mavenLocal() } } if (project.getProperty('status').equals("snapshot")) { repositories { maven { url 'http://oss.jfrog.org/oss-snapshot-local' } } }

}

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Netflix/ribbon/issues/332, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvvFjwKfP1_HIqYJwsctyVE4cCLElYvks5rmnGFgaJpZM4MgfI3 .

WreathCrystal commented 7 years ago

@lorgine Have you fixed your issue? I have the same problem.

rspieldenner commented 7 years ago

Upgrade to the newest version of gradle and the nebula.netflixoss plugin. That earlier version required a git repository to operate On Wed, Jul 26, 2017 at 10:44 PM polarcoral notifications@github.com wrote:

@lorgine https://github.com/lorgine Have you fixed your issue? I have the same problem.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Netflix/ribbon/issues/332#issuecomment-318264721, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvvFn3uR81U_iCLybGM2RrF6-VFvfnwks5sSCPJgaJpZM4MgfI3 .

WreathCrystal commented 7 years ago

@rspieldenner Another issue occurs after upgrading to the newest version both of gradle and the nebula.netflixoss plugin.

The content of build.gradle as below: plugins { id 'nebula.netflixoss' version '3.5.2' }

// Establish version and status ext.githubProjectName = rootProject.name // Change if github project name is not the same as the root project's name

subprojects { apply plugin: 'nebula.netflixoss' apply plugin: 'java'

sourceCompatibility = 1.7
targetCompatibility = 1.7

group = "com.netflix.${githubProjectName}" // TEMPLATE: Set to organization of project

repositories {
    jcenter()
}

if (project.hasProperty('useMavenLocal')) {
    repositories {
        mavenLocal()
    }
}
if (project.getProperty('status').equals("snapshot")) {
    repositories {
        maven { url 'http://oss.jfrog.org/oss-snapshot-local' }
    }
}

}

The gradle version as attachment gradle

Another errors : image

WreathCrystal commented 7 years ago

@rspieldenner Maybe you can tell me the accurate version both of gradle and nebula.netflixoss plugin with which ribbon project will be imported and built successfully.

rspieldenner commented 7 years ago

Either gradle 4.0.2 or 4.1-rc-1 nebula.netflixoss -> 3.6.4

Need to modify ribbon/build.gradle to start with

apply plugin: 'nebula.test-jar' // deprecated plugin was renamed
apply plugin: 'nebula.facet' // plugin was renamed

task licenseExamples(type: nl.javadude.gradle.plugins.license.License) // create license task for custom source set (which I'll look at at work since this should be automatic)

And there is a failing test. ListenerTest. testFailedExecutionForAbsoluteURI

I would need the ribbon team to weigh in on the failing test.

WreathCrystal commented 7 years ago

When I modify ribbon/build.gradle to start with:

apply plugin: 'nebula.test-jar' // deprecated plugin was renamed apply plugin: 'nebula.facet' // plugin was renamed apply plugin: 'nebula.netflixoss'

the error as below: image

Then I commented out the code of NetflixOssProjectPlugin.groovy file of gradle-netflixoss-project-plugin project which I got from the website: https://github.com/nebula-plugins/gradle-netflixoss-project-plugin

image

Then I replaced the NetflixOssProjectPlugin.class file in gradle-netflixoss-project-plugin-3.6.4.jar with the just complied local file NetflixOssProjectPlugin.class

the error changed:

image

WreathCrystal commented 7 years ago

Then I insert lines to ribbon/build.gradle

plugins { id "nebula.nebula-test-jar" version "2.2.2" }

The import error changes to this:

image

WreathCrystal commented 7 years ago

@rspieldenner I can import ribbon project successfully now. Thank you ! But I think the error as below maybe a bug? what do you think? image

There is another problem left. When I import missing dependency http-20070405.jar into ribbon/ribbon-loadbalance project, I got one error: The method setSSLParameters(SSLParameters) is undefined for the type HttpsParameters

image

This maybe caused by http.jar version confict, Which version you are using?

WreathCrystal commented 7 years ago

@rspieldenner You said :
--- > There is a failing test. ListenerTest. testFailedExecutionForAbsoluteURI I saw this test case. What you mean? You can get my import ribbon project running information via the test case remotely?

-----> I would need the ribbon team to weigh in on the failing test. What I can do for you when you need the ribbon team to weigh in on the failing test?

rspieldenner commented 7 years ago

I work on the nebula plugins so I can help get the build working. There is another team that works on the ribbon project itself that will better understand any test failures. On Fri, Jul 28, 2017 at 2:38 AM polarcoral notifications@github.com wrote:

@rspieldenner https://github.com/rspieldenner You said : --- > There is a failing test. ListenerTest. testFailedExecutionForAbsoluteURI I saw this test case. What you mean? You can get my import ribbon project running information via the test case remotely?

-----> I would need the ribbon team to weigh in on the failing test. what I can do for you when you need the ribbon team to weigh in on the failing test?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Netflix/ribbon/issues/332#issuecomment-318608415, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvvFomK9IRex558WQXBNbD_shgKRc7Iks5sSawKgaJpZM4MgfI3 .

rspieldenner commented 7 years ago

I saw the test failure since I cloned ribbon locally and updated my copies gradle and nebula.netflixoss and made the changes I asked you to make. Then ran './gradlew build' and had that test failure. On Fri, Jul 28, 2017 at 7:24 AM Rob Spieldenner rob.spieldenner@gmail.com wrote:

I work on the nebula plugins so I can help get the build working. There is another team that works on the ribbon project itself that will better understand any test failures. On Fri, Jul 28, 2017 at 2:38 AM polarcoral notifications@github.com wrote:

@rspieldenner https://github.com/rspieldenner You said : --- > There is a failing test. ListenerTest. testFailedExecutionForAbsoluteURI I saw this test case. What you mean? You can get my import ribbon project running information via the test case remotely?

-----> I would need the ribbon team to weigh in on the failing test. what I can do for you when you need the ribbon team to weigh in on the failing test?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Netflix/ribbon/issues/332#issuecomment-318608415, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvvFomK9IRex558WQXBNbD_shgKRc7Iks5sSawKgaJpZM4MgfI3 .