Netflix / security_monkey

Security Monkey monitors AWS, GCP, OpenStack, and GitHub orgs for assets and their changes over time.
Apache License 2.0
4.35k stars 799 forks source link

RDS db instance watcher not paginating #820

Open scriptsrc opened 7 years ago

scriptsrc commented 7 years ago

The watcher for RDS DB Instances is not paginating the call to describe db instances:

https://github.com/Netflix/security_monkey/blob/develop/security_monkey/watchers/rds/rds_db_instance.py#L96

boto3 does use markers for this call:

http://boto3.readthedocs.io/en/latest/reference/services/rds.html#RDS.Client.describe_db_instances

mikegrima commented 6 years ago

We should move this over to CloudAux.