search

Netflix / servo

Netflix Application Monitoring Library
Apache License 2.0
1.42k stars 297 forks source link

switch to no op monitor registry by default #466

Closed brharrington closed 4 years ago

brharrington commented 4 years ago

Internally Servo is deprecated and delegates to Spectator. This change would reduce the overhead for things that are still using the Servo APIs. The main benefit is that the data would no longer be exported to JMX.

Note, this could be quite disruptive to anyone else using Servo. Since it is all setup via sytem properties, there isn't a convenient way to only change the default we use internally.

After making this change, I noticed that loading the JMX monitor registry explicitly using the property no longer worked. That has been fixed so the old behavior can be acheived using a system property.

brharrington commented 4 years ago

What did you have in mind? Just a section towards the top of the readme?

dmuino commented 4 years ago

Yes, something that would be easy to catch for someone looking at this project after something unexpected happens with the new version, like not being able to see the metrics under JMX.