Netflix / unleash

Professionally publish your JavaScript modules in one keystroke
http://netflix.github.io/unleash/
Apache License 2.0
595 stars 26 forks source link

Does not update package.json with version #21

Open caseytrombley opened 5 years ago

caseytrombley commented 5 years ago

This package is not automatically updating the version in my package.json. It adds to the changelog only. Here is the command I use: unleash --no-publish

This is the console message:

$ unleash --no-publish --minor
[13:31:25] === UNLEASH ===
[13:31:25] Utilizing next version for changelog:  2.9.0
[13:31:25] Using repo type:  github
[13:31:25] Generating changelog from origin to HEAD...
[13:31:25] Parsed 0 commits.
[13:31:25]  
[13:31:29] [DS-22691_bumpVersion f25f7be] docs(CHANGELOG): Update changelog
 1 file changed, 4 insertions(+)
 husky > pre-commit (node v10.14.0)
No staged files match any of provided globs.
husky > commit-msg (node v10.14.0)

[13:31:29] Utilizing bumpType minor
[13:31:29] Retrieving latest git commit...
[13:31:29] Getting next version of type:  minor
[13:31:29] Incrementing from version:  2.8.1
[13:31:29] Bumped 'package.json' version to: 2.9.0
[13:31:30] On branch DS-22691_bumpVersion
nothing to commit, working tree clean
 husky > pre-commit (node v10.14.0)
No staged files match any of provided globs.

[13:31:30] Tagging as: v2.9.0
[13:31:30]  
[13:31:33]  To https://mycompany/my-repo.git
 * [new branch]      DS-22691_bumpVersion -> DS-22691_bumpVersion
 * [new tag]         origin -> origin
 * [new tag]         v2.9.0 -> v2.9.0

✨  Done in 9.29s.

We are not seeing any change to package.json

cktech1me commented 4 years ago

I'm also seeing this issue.

$ node -v
v10.14.1
$ npm -v
6.4.1
$ sw_vers
ProductName:    Mac OS X
ProductVersion: 10.14.5
BuildVersion:   18F203
cktech1me commented 4 years ago

$ unleash --no-publish --no-push --dry-run --patch [11:40:29] === UNLEASH === [11:40:29] Utilizing dry run mode. This is a dry run of the following actions: [11:40:29] Incrementing to the next "patch" semantic version, "0.4.2" [11:40:29] Creating a changelog entry for version 0.4.2 with links to the commits on github [11:40:29] Adding commit "docs(CHANGELOG): Update changelog" [11:40:29] Bumping to a patch version with the commit "chore(release): release 0.4.2" [11:40:29] * Tagging the commit with "v0.4.2" [11:40:29] ~ WARNING ~ [11:40:29] You've turned both publishing & pushing off. Your changelog & package files will be updated + committed locally but nothing outside your machine will change. [11:40:29] unleash --no-publish --no-push --dry-run --patch ✨ Done in 1.34s. <-- The package.json remains at 0.4.1...

jameswomack commented 4 years ago

@caseytrombley @cktech1me Each of those commands work for me. Which Unleash version are you using? I use Unleash to release itself as well as a few other repos and v2.0.1 & v2.0.2 have both been working. Perhaps updating to v2.0.2 will help