search

Netflix / vmaf

Perceptual video quality assessment based on multi-method fusion.
Other
4.34k stars 735 forks source link

cambi.c: validate input value ranges #1355

Closed nilfm99 closed 3 months ago

nilfm99 commented 3 months ago

Replaces #1352. Benchmarks on my laptop show no observable overhead wrt master but need to check further.

(my benchmarks were on a 10-bit input so it's not just because of the early return in 8-bit and 16-bit cases)

nilfm99 commented 3 months ago

Benchmarks on 10-bit input on a Macbook M1 show no significant difference. Benchmarks on 10-bit input on an ubuntu machine with AMD cpu show 1% performance degradation.

Both cases running just CAMBI, single-threaded.

kylophone commented 3 months ago

LGTM for now. Might need to revisit if we need to go after CAMBI speedups.