search

Netflix / vmaf

Perceptual video quality assessment based on multi-method fusion.
Other
4.34k stars 735 forks source link

test_feature_extractor: add thread_lib dependency #1363

Closed 1480c1 closed 2 months ago

1480c1 commented 2 months ago

msys2's clang64 environment errors out due to undefined symbols with pthread. The non-clang environments are fine as gcc implicitly links pthread.

Fixes https://github.com/Netflix/vmaf/issues/1362

1480c1 commented 2 months ago

image

Compilation and test works locally. Also checked with ucrt64 and mingw64 and they all pass.

nilfm99 commented 2 months ago

I opened #1364 to fix the ffmpeg CI issue, do you know why the other tests may be failing?

nilfm99 commented 2 months ago

alright, I see that the other failure also has nothing to do with this PR, no idea how it got introduced 😞

This one LGTM, we will get it in after fixing that error