search

Netflix / x-element

A dead simple starting point for custom elements.
Apache License 2.0
28 stars 12 forks source link

Skip initial lookup for internal properties. #130

Closed theengineear closed 1 year ago

theengineear commented 1 year ago

Internal properties should be completely decoupled from the public interface. This change set adds a guard to ensure that we don’t try to lookup the property name on the public interface when upgrading the element.

Closes #129.

theengineear commented 1 year ago

For context — I'd consider this a bug with the current implementation. I don't think there should be any conceptual argument about the behavior here. We just need to add in this guard.

theengineear commented 1 year ago

@klebba — This is a pretty small change and since we already caught up on it offline, I'm just going to merge it.