search

Netflix / x-element

A dead simple starting point for custom elements.
Apache License 2.0
29 stars 12 forks source link

Bump requirements and add ignore #181

Closed Kelketek closed 3 months ago

Kelketek commented 3 months ago

This PR bumps requirements per npm audit, and also adds an entry for .nvmrc into .gitignore for those using nvm to manage different versions of node locally.

Testing instructions:

  1. npm install
  2. npm start &
  3. npm test ...or just let CI do its thing.

Author notes and concerns:

Just a small thing I found when playing with this repo. Not sure if you have any other required checks before doing requirements updates. Hope to have more stuff for you soon.

Also I used conventional commit syntax for the commit memos, but you don't seem to be using that standard. Please let me know if you have a preferred set of conventions for labeling commits.

Kelketek commented 3 months ago

Closing in favor of #180 , which bumps requirements directly.