search

Netflix / x-element

A dead simple starting point for custom elements.
Apache License 2.0
29 stars 12 forks source link

Improve internal “template engine”. #188

Closed theengineear closed 1 month ago

theengineear commented 1 month ago

Nearly all of the template engine details are kept internal — this allowed us to ship a first pass of the code without needed high-levels of scrutiny. However, we can (and will!) revisit this internal code to make it more readable / self-documenting.

Closes #187.

theengineear commented 1 month ago

@klebba — I was motivated by some recent activity in here to start making some improvements to the internal TemplateEngine code. I’m certain that there’s more to be done here, but I think this is a decent iteration.

The TL;DR is that I’ve removed some poor abstraction layers in favor of moving towards a single class called TemplateEngine.

theengineear commented 1 month ago

@klebba — Going to get this merged in. I’m only making internal changes so no interface changes here. I also punted the documentation portion out and I can open up a new PR to address that.

klebba commented 1 month ago

Nice work!