search

Netflix / x-element

A dead simple starting point for custom elements.
Apache License 2.0
28 stars 12 forks source link

Add listeners block to x-element base. #32

Closed theengineear closed 5 years ago

theengineear commented 5 years ago

A new listeners-mixin exists which is meant to be more low-level than the properties-mixin. It allows us to pull out some code that’s not strictly needed for the element-mixin, which mostly wants to concern itself with necessities for creating custom elements.

Closes #29

theengineear commented 5 years ago

@klebba , what do you think creating a new listeners-mixin? I have a fear of adding too much to the element-mixin class as it only serves to bloat x-element-basic. I think it's a useful goal to keep element-mixin as incredibly thin as possible. Thoughts?

theengineear commented 5 years ago

@klebba decided to leave those methods in the element-mixin. Curious to hear your thoughts on the polymer deprecation of listen and unlisten though!