search

Netflix / x-element

A dead simple starting point for custom elements.
Apache License 2.0
28 stars 12 forks source link

data-* warning irrelevant for internal properties #74

Closed reliable-casey closed 3 years ago

reliable-casey commented 3 years ago

Given that internal properties may not be attribute bound or reflected, it probably makes sense to relax this warning in this case.

theengineear commented 3 years ago

I wrote up a long response, but... perhaps a return question would be more helpful.

Rather than "relax this warning", do you really mean "should internal properties register a related attribute at all"?

I'm less-inclined to do the former, but a broader change to stop registering attributes for internal properties would potentially be more reasonable.

(For context, all properties are currently associated with an attribute — even internal ones. That's how we are able to throw an error if an integrator attempts to update an internal property through an attribute.)

Thoughts @klebba?

reliable-casey commented 3 years ago

Yeah, that's a great point — I would agree that internal properties should not register a related attribute at all