search

Netflix / x-element

A dead simple starting point for custom elements.
Apache License 2.0
28 stars 12 forks source link

DX-1080: Use mixin pattern for x-element. #9

Closed theengineear closed 5 years ago

theengineear commented 5 years ago

This pattern is copied from how polymer-element works:

https://github.com/Polymer/polymer/blob/master/polymer-element.js

The mixin pattern is detailed here:

http://justinfagnani.com/2015/12/21/real-mixins-with-javascript-classes/

klebba commented 5 years ago

Minor comment -- we should not reference internal JIRA tickets in commits here

theengineear commented 5 years ago

Minor comment -- we should not reference internal JIRA tickets in commits here

ha, yah, i was wondering about that when I pushed it up. makes sense

klebba commented 5 years ago

I have a request ... can we include the reflect compatibility change here too? So reflectToAttribute and reflect would both work

klebba commented 5 years ago

Overall looks great -- we should be able to merge this outline, only real request is that we restore the non-standard imports: x-element-basic.js and x-element-properties.js

theengineear commented 5 years ago

Closing in favor of #10